Re: [PATCH v5 2/2] gpio: sn65hvs885: Add DT binding documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Jan 26, 2016 at 08:32:46AM +0100, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@xxxxxxxxx>
> ---
> Changes since v4:
> - Added description, required properties
> - Tested and added support for gpio polarity
> - Added vendor prefix to compatible flags
> 
> Changes since v3:
> - Added gpio-controller and gpio cells flags
> 
>  .../devicetree/bindings/gpio/gpio-sn65hvs885.txt     | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt

This looks fine, but I just realized this is the same thing as this[1]. 
Please coordinate these bindings. 

Rob

[1] https://lkml.org/lkml/2016/1/25/781

> 
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
> new file mode 100644
> index 0000000..c9b3592
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-sn65hvs885.txt
> @@ -0,0 +1,20 @@
> +* TI SN65HVS885 digital-input serializer
> +
> +Required properties:
> +- compatible : Should be "ti,sn65hvs885"
> +- reg : chip select number
> +- gpio-controller : Marks the device node as a gpio controller.
> +- #gpio-cells : Should be two.  The first cell is the pin number and
> +  the second cell is used to specify the gpio polarity:
> +      0 = active high
> +      1 = active low
> +
> +Example:
> +sn65hvs885@3 {
> +	compatible = "ti,sn65hvs885";
> +	spi-max-frequency = <10000000>;
> +	latch-gpio = <&gpio4 1 GPIO_ACTIVE_HIGH>;
> +	reg = <0>;
> +	gpio-controller;
> +	#gpio-cells = <2>;
> +};
> -- 
> 2.7.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux