On Tue, Jan 26, 2016 at 03:54:13PM -0800, Florian Fainelli wrote: > On 26/01/16 14:09, Andrew Lunn wrote: > >>> Nope, not an option. Only a small number of DTB actually use c22 or > >>> c45. The majority of devices have no compatible at all. Why should > >>> they, the binding documentation says it is optional! > >> > >> So one thing that can be done is to just have a whitelist in the > >> driver that we add the known phy compatibles to, with a nice comment > >> above that this should only be for legacy device trees. > > > > So you mean drivers/of/of_mdio.c:of_mdiobus_child_is_phy() > > has a white list like: > > > > "brcm,40nm-ephy" > > "marvell,88E1111", > > "marvell,88e1116", > > "marvell,88e1118", > > "marvell,88e1149r", > > "marvell,88e1310", > > "marvell,88E1510", > > "marvell,88E1514", > > "moxa,moxart-rtl8201cp", > > > > Yes, that would work. > > > > We should also update the binding documentation to limit what is legal > > in the compatible string. > > Agreed, and while at it, take the opportunity to make the compatible > string clause 22/45 mandatory properties so we do not multiply the > whitelist. Hi Florian I just posted the whitelist code. Making clause 22/45 mandatory is going further than a fix. So i've left this out for the moment. We can add it to net-next later. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html