>>>>> "Yang," == Yang, Wenyou <Wenyou.Yang@xxxxxxxxx> writes: Hi, >> > The MFD sub device is registered as a platform device, the existing > act8865 >> driver is registered as an i2c_driver. How do they match? :) >> >> > Could you point out which exiting driver for me to reference. Thank you! >> >> What I'm saying is that it isn't nice that we end up with both act8865-regulator.c >> and act8954-regulator.c doing 95% the same. This can either be fixed by: >> >> - Adding act8865 support to your mfd driver (but only registering the >> regulator subdev for act8865) and changing the existing >> act8865-regulator driver to work as a mfd subdev (platform device) >> >> - Extending the act8865-regulator driver to register as a platform >> driver in ADDITION to a i2c driver so it can be used with mfd. The >> driver already uses regmap so it should only be a matter of adding the >> pdev probe/remove functions. > After think twice, I think this will complicates the act8865-regulator driver. I don't think it will add a lot of complication (E.G. basically just the platform probe/remove functions), but Ok - I'll wait and see your simplified driver. -- Venlig hilsen, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
