Hi Rob, Please, is there any update regarding of my question? Thank you! Best Regards Zhao Qiang > -----Original Message----- > From: Qiang Zhao > Sent: Monday, January 11, 2016 4:19 PM > To: 'Rob Herring' <robh@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linuxppc- > dev@xxxxxxxxxxxxxxxx; Priyanka.Jain@xxxxxxxxxxxxx; oss@xxxxxxxxxxxx > Subject: RE: [PATCH 3/6] QE: Add uqe_serial document to bindings > > On Fri, Jan 09, 2016 at 04:12AM, Rob Herring <robh@xxxxxxxxxx> wrote: > > -----Original Message----- > > From: Rob Herring [mailto:robh@xxxxxxxxxx] > > Sent: Saturday, January 09, 2016 4:12 AM > > To: Qiang Zhao <qiang.zhao@xxxxxxx> > > Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > > linuxppc- dev@xxxxxxxxxxxxxxxx; Priyanka.Jain@xxxxxxxxxxxxx; > > oss@xxxxxxxxxxxx > > Subject: Re: [PATCH 3/6] QE: Add uqe_serial document to bindings > > > > On Fri, Jan 08, 2016 at 10:18:11AM +0800, Zhao Qiang wrote: > > > Add uqe_serial document to > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx> > > > --- > > > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 20 > > ++++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx > > > t > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.tx > > > t > > > new file mode 100644 > > > index 0000000..e677599 > > > --- /dev/null > > > +++ > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial. > > > +++ txt > > > @@ -0,0 +1,20 @@ > > > +* Serial > > > + > > > +Currently defined compatibles: > > > +- ucc_uart > > > + > > > +Properties for ucc_uart: > > > +device_type : which type the device is > > > > Drop this please. > > Yes, I will drop it in next version. > > > > > > +port-number : port number of UCC-UART > > > > Use aliases instead. > > I don't understand, can you explain more? > > > > > > +rx-clock-name : which clock QE use for RX tx-clock-name : which > > > +clock QE use for TX > > > > These should use the clock binding. > > This property means which clock source the UCC use, the QE just use this > property to route UCC clock to clock source. > The clock source maybe either internal or outside(from clock input pin). > So clock binding is not apply in this case. > > > > > > + > > > +Example: > > > + > > > + serial: ucc@2200 { > > > + device_type = "serial"; > > > + compatible = "ucc_uart"; > > > + port-number = <1>; > > > + rx-clock-name = "brg2"; > > > + tx-clock-name = "brg2"; > > > + }; > > > -- > > > 2.1.0.27.g96db324 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe devicetree" > > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > majordomo > > > info at http://vger.kernel.org/majordomo-info.html > Best Regards > Zhao Qiang -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html