Hi Philipp,
Thanks for the quick review,
On 01/15/16 15:57, Philipp Zabel wrote:
Am Freitag, den 15.01.2016, 14:44 +0000 schrieb James Hartley:
[..]
+Example:
+
+ pistachio_reset: reset-controller {
+ compatible = "img,pistachio-reset";
+ img,cr-periph = <&cr_periph>;
+ #reset-cells = <1>;
+ };
If this is just a register in the cr_periph syscon, why not put the
reset-controller node inside the cr_periph node:
cr_periph: syscon@xyz {
compatible = "syscon", "simple-mfd";
pistachio_reset: reset-controller {
compatible = "img,pistachio-reset";
#reset-cells = <1>;
};
};
And in the driver use
syscon_node_to_regmap(np->parent);
instead of
syscon_regmap_lookup_by_phandle(np, "img,cr-periph");
?
Yes that makes sense, I'll look at changing that for a V2 patchset.
Do you need a reg property, or is will the register offset be 0 in all
pistachio variants?
The offset will always be 0 for all pistachio variants.
[..]
+Example:
+
+ spdif_out: spdif-out@18100d00 {
+ ...
+ resets = <&pistachio_reset PISTACHIO_RESET_SPDIF_OUT>;
+ reset-names = "rst";
reset-names is not needed for devices that only have one reset.
Agreed, but there are already audio drivers that pistachio uses that
have been merged upstream
using this name in their dt-entries - is there any harm in leaving it in?
regards
Philipp
Thanks,
James.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
