On Wed, Dec 30, 2015 at 5:22 AM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> Hi Rob,
>
> Thanks for the review.
>
> On 29/12/15 18:35, Rob Herring wrote:
>>
>> On Wed, Dec 23, 2015 at 12:10:11PM +0000, Sudeep Holla wrote:
>>>
>>> Juno r2 is identical to Juno r1 with Cortex A57 cores replaced by
>>> Cortex A72 cores.
>>
>>
>> That's a bigger change than I'd expect...
>>
>
> I am not sure if I understood what you meant by that. Do you want me to
> elaborate with more details ?
No, just my commentary that I'd expect r1 -> r2 to be a board or Si
spin rather than a whole new core.
>>> Acked-by: Liviu Dudau <Liviu.Dudau@xxxxxxx>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
>>> ---
>>> Documentation/devicetree/bindings/arm/arm-boards | 1 +
>>> Documentation/devicetree/bindings/arm/cpus.txt | 1 +
>>
>>
>> This should probably be a separate patch, but I already have a patch in
>> my tree for 4.5 adding arm,cortex-a72. So just drop this hunk.
>>
>
> OK, will post DT binding separately.
No need, it is already in my tree.
>>> + pcie-controller@40000000 {
>>> + compatible = "arm,juno-r1-pcie", "plda,xpressrich3-axi",
>>> "pci-host-ecam-generic";
>>
>>
>> Is this common with r1?
>>
>
> AFAIK it is. Liviu can you confirm ?
Then perhaps you should move this to a common spot.
Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
