On Wed, Dec 23, 2015 at 11:38:29AM +0000, Reizer, Eyal wrote:
> - Add support for getting the platform data which includes the uart
> used and gpio pin used for enable from device tree.
>
> - Fix the implementation for using device handle for the uart and
> gpiod for the enable pin, instead of device name (as string) used
> for the uart and pio number which are both bad practice.
>
> Signed-off-by: Eyal Reizer <eyalr@xxxxxx>
> ---
> Documentation/devicetree/bindings/misc/ti-st.txt | 42 ++++++
> arch/arm/mach-omap2/pdata-quirks.c | 16 ++-
> drivers/misc/ti-st/st_kim.c | 159 ++++++++++++++++------
> drivers/misc/ti-st/st_ll.c | 16 ++-
> include/linux/ti_wilink_st.h | 13 +-
I'd suggest you look at commit c0bd1b9e58959c5 (Revert "ti-st: add
device tree support") first.
> 5 files changed, 190 insertions(+), 56 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/misc/ti-st.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/ti-st.txt b/Documentation/devicetree/bindings/misc/ti-st.txt
> new file mode 100644
> index 0000000..4490da6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/ti-st.txt
> @@ -0,0 +1,42 @@
> +TI Wilink 6/7/8 (wl12xx/wl18xx) Shared transport driver
Bindings shouldn't be describing drivers...
> +
> +TI’s Wireless Connectivity chips support Bluetooth (BT), WiFi, and GPS
> +technology cores in a single die.
> +
> +Such a multi-core combo chip will be interfaced to the application processor
> +using a single physical port (like UART).
> +
> +Shared Transport (ST) software enables BT and GPS protocols or software
> +components to interact with their respective cores over single physical port.
> +ST uses logical channels, over physical transport, to communicate with
> +individual cores.
> +
> +Logical channels 1, 2, 3, and 4 are used for BT packets, channel 8 for FM,
> +channel 9 for GPS and channels 30, 31, 32, and 33 are used for Chip Power
> +Management (PM).
All this is irrelevant for a binding.
> +
> +This node provides properties for passing parameters to the ti shared
> +transport driver.
> +
> +Required properties:
> + - compatible: should be the following:
> + * "kim" - ti-st parameters
Who is kim? Certainly not a description of a h/w block.
> +
> +Optional properties:
> + - nshutdown-gpios : specifies attributes for gpio ping used for enabling
> + the bluetooth,gps and FM sub systems
> + - serial-device : the phandle for the phisical uart used for interacting
> + with the wilink device
There have been multiple discussions on serial slave devices recently.
I'm not going to accept any device binding without a common uart slave
device binding first.
> + - flow_cntrl : Indicates if uart flow control is used
> + - flow_cntrl : uart baud rate in BPS
Typo here, but these should be part of a common serial slave binding.
Don't use '_' in property names.
> +
> +Example:
> +
> +kim {
> + compatible = "kim";
> + nshutdown-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> + serial-device = <&uart1>;
> + flow_cntrl = <1>;
> + flow_cntrl = <3000000>;
> +};
> +
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
