On 12/05/2015 02:43 AM, Stefan Wahren wrote:
>
>> Stephen Warren <swarren@xxxxxxxxxxxxx> hat am 2. Dezember 2015 um 04:42
>> geschrieben:
>>
>>
>> On 11/19/2015 09:06 AM, Stefan Wahren wrote:
>>> The node name of the sdhci pin group doesn't explain it's
>>> real function. So rename it.
>>
>> The real function of this node is not to configure SDHCI pins, but to
>> set pins to alt3, as the current name states. Admittedly it's possible
>> that currently the only pins that need to be set to ALT3 are SDHCI
>> related, but that's incidental.
>
> Yes, i understand the original intension to assign every pin to the available
> mux functions ( gpio_in, gpio_out, alt* ).
>
> But 3f37169fb3 ("ARM: bcm2835: dt: Add Raspberry Pi Model B rev2") introduce a
FYI I don't have that yet and git fetch is being very slow right now:-(
> better self-describing pin group naming for I2S. So my idea was to adapt it
> according to sdhci first and go on.
OK. I'd suggest explaining that directly in the commit description then.
The commit description above has a quite different semantic meaning.
> So here is a possible vision for bcm2835-rpi.dtsi
>
> &gpio {
> pinctrl-names = "default";
>
> act_gpio: gpio {
> brcm,pins = <6>;
> brcm,function = <BCM2835_FSEL_GPIO_OUT>;
> };
>
> i2c0_alt0: i2c {
> brcm,pins = <0 1>;
> brcm,function = <BCM2835_FSEL_ALT0>;
> };
>
> i2c1_alt0: i2c {
> brcm,pins = <2 3>;
> brcm,function = <BCM2835_FSEL_ALT0>;
> };
...
OK, I guess that can work; I imagine it would make DT overlays easier by
making the pinctrl setup more fine-grained.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
