On Wed, Dec 09, 2015 at 11:47:58AM +0100, Alexander Aring wrote: > Example: the error case is while probing, how we react on a -EBUSY there > "in an error case" -> simple ignore it? But then nobody see that the use > of this function is wrong. The proper way to deal with functionality that can only be registered but never removed is to report the error, but never fail during probing, and never allow removal (empty removal function.) If you return a failure code during probe, you end up in an inconsistent situation where you have facilities registered, but resources that those facilities require will be undone when probe() returns a failure, and that can potentially lead to kernel oops or scribbling over someone elses device or memory. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html