On Mon, Dec 7, 2015 at 12:13 PM, Brian Norris <computersforpeace@xxxxxxxxx> wrote: > On Sun, Dec 06, 2015 at 08:45:40PM -0600, Rob Herring wrote: >> On Fri, Dec 4, 2015 at 11:19 PM, Brian Norris >> <computersforpeace@xxxxxxxxx> wrote: >> > drivers/of/of_mtd.c | 33 +++++++++++++++++++++++++++++++++ >> >> BTW, this file should be moved to drivers/mtd/ at some point. > > How about s/at some point/now/ ? Great. > I can send a separate patch. It also > seems like these should just get linked into the 'mtd' module (when > CONFIG_OF=y) instead of having a tiny module for just a few functions. Agreed. > Why did files like this get placed here anyway? Is there a reason that > there are things like of_net and of_pci here too? Things started out here, but as the number of subsystems and associated bindings grew it became evident that binding specific things should go with the subsystems. I also have a secret goal to eliminate drivers/of. Don't tell anyone. of_net should probably move, just no one has had the itch to do it. PCI is a bit special and somewhat tied into the rest of the core. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html