> -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: 20 November, 2015 17:45 > To: Tirdea, Irina > Cc: Dmitry Torokhov; Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@xxxxxxxxxxxxxxx; Mark Rutland; Purdila, Octavian; > linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v11 6/8] Input: goodix - add support for ESD > > On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: > > Add ESD (Electrostatic Discharge) protection mechanism. > > [...] > > > This is based on Goodix datasheets for GT911 and GT9271 and on Goodix > > driver gt9xx.c for Android (publicly available in Android kernel > > trees for various devices). > > > > Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx> > > For the binding: Acked-by: Rob Herring <robh@xxxxxxxxxx> > > You should not have the "For the binding:" part here. It was just a note > so it was clear what part I looked at. > I saw it done like that in another patch already merged, so I thought it's the right way [1]. Dmitry, could you fix this at merge or you need me to send another patchset? Thanks, Irina [1] https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/commit/?id=d2a3e0931a8f3b95b910096d022ffd98adbd075c > It is preferred to split DT bindings to separate patches for this > reason. > > > Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx> > > --- > > .../bindings/input/touchscreen/goodix.txt | 4 + > > drivers/input/touchscreen/goodix.c | 160 ++++++++++++++++++++- > > 2 files changed, 159 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
