On Fri, Nov 20, 2015 at 7:44 AM, Rob Herring <robh@xxxxxxxxxx> wrote: > On Thu, Nov 19, 2015 at 02:26:39PM +0200, Irina Tirdea wrote: >> Add ESD (Electrostatic Discharge) protection mechanism. > > [...] > >> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix >> driver gt9xx.c for Android (publicly available in Android kernel >> trees for various devices). >> >> Signed-off-by: Irina Tirdea <irina.tirdea@xxxxxxxxx> >> For the binding: Acked-by: Rob Herring <robh@xxxxxxxxxx> > > You should not have the "For the binding:" part here. It was just a note > so it was clear what part I looked at. > > It is preferred to split DT bindings to separate patches for this > reason. > It however does not make sense if one wants to research when and why something was changed. We do not split patches to .h files from .c either. Whenever I can I merge the driver and dt binding changes together if they have been posted and reviewed as separate patches. The Acks/Reviewed are mostly important for maintainers anyway. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html