On Mon, Nov 16, 2015 at 12:38:15PM +0100, Lucas Stach wrote:
<snip>
> > > > + reg_sd3_vmmc: sd3_vmmc {
> > > > + compatible = "regulator-fixed";
> > > > + regulator-name = "P3V3_SD3_SWITCHED";
> > > > + regulator-min-microvolt = <3300000>;
> > > > + regulator-max-microvolt = <3300000>;
> > > > + gpio = <&gpio1 4 GPIO_ACTIVE_LOW>;
> > > > + regulator-boot-on;
> > > > + regulator-always-on;
> > > > + };
> > >
> > > A lot of those regulators look like they don't need to be always-on.
> > >
> > > Also the use of a simple-bus, while giving some structure to the DT is
> > > considered bad style as it doesn't reflect any real hardware.
> > >
> >
> > I will check how other boards do it
> >
> Note that there are a lot of bad examples still around. What you need to
> do is essentially just remove the additional DT level of the regulator
> bus. The regulators are board components that belong to the same level
> as the usb hub below, or the memory node above.
Will kernel populate platform_device for these fixed regulators if they
are being put directly under root node? Kernel used to only do that for
devices under simple-bus.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
