> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
It is not normal to specify the root device. Is this really required?
And rootdelay is also unusual.
> + stdout-path = &uart0;
> + };
> +
> + ocp@f1000000 {
> + pinctrl: pin-controller@10000 {
> + pmx_usb_power_enable: pmx-usb-power-enable {
> + marvell,pins = "mpp29";
> + marvell,function = "gpio";
> + };
> + pmx_led_white: pmx-led-white {
> + marvell,pins = "mpp40";
> + marvell,function = "gpio";
> + };
> + pmx_led_green: pmx-led_green {
> + marvell,pins = "mpp46";
That last _ should be -..
> + marvell,function = "gpio";
> + };
> + pmx_led_orange: pmx-led-orange {
> + marvell,pins = "mpp47";
> + marvell,function = "gpio";
> + };
> + };
> + serial@12000 {
> + status = "ok";
> + };
> +
> + sata@80000 {
> + status = "okay";
> + nr-ports = <2>;
> + };
> +
> + };
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
This does not fit the naming convention. status should be the machine
name.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
