Hi Grant, > > Acked-by: Stephen Warren <swarren@xxxxxxxxxx> > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > > Signed-off-by: Florian Lobmaier <florian.lobmaier@xxxxxxx> > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> <snip> > > + Optional properties: > > + ------------------- > > + The input supply of regulators are the optional properties on the > > + regulator node. The input supply of these regulators are provided > > + through following properties: > > + vsup-sd2-supply: Input supply for SD2. > > + vsup-sd3-supply: Input supply for SD3. > > + vsup-sd4-supply: Input supply for SD4. > > + vsup-sd5-supply: Input supply for SD5. > > + vin-ldo0-supply: Input supply for LDO0. > > + vin-ldo1-6-supply: Input supply for LDO1 and LDO6. > > + vin-ldo2-5-7-supply: Input supply for LDO2, LDO5 and LDO7. > > + vin-ldo3-4-supply: Input supply for LDO3 and LDO4. > > + vin-ldo9-10-supply: Input supply for LDO9 and LDO10. > > + vin-ldo11-supply: Input supply for LDO11. > > What is the data in these properties? The documentation isn't clear. > > In principle, the binding looks okay to me. The properties to which you refer are standard regulator supply bindings specified here [1]. Specifically: "<name>-supply: phandle to the parent supply/regulator node" The DT portion has already been Acked by Stephen and applied by me. [1] Documentation/devicetree/bindings/regulator/regulator.txt -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html