On Thu, 24 Oct 2013 00:49:42 +0200, Sebastian Reichel <sre@xxxxxxxxxx> wrote: > On Wed, Oct 23, 2013 at 05:24:14PM -0500, Rob Herring wrote: > > So a twl4030 device is only a power button? DT should describe the h/w > > not a node for a sub-function of a device. > > No. TWL4030 is a companion chip for the OMAP3 processor. It provides > miscellaneous functionality, e.g.: > > * RTC > * Watchdog > * Regulators > * Keypad Matrix > * USB > * Audio > * Vibrator > * GPIO > * ... > > One part of the functionality is the power button. The patch > assumes, that the twl4030-pwrbutton node is used as follows: > > twl { > /* ... common stuff ... */ > > pwrbutton { > compatible = "ti,twl4030-pwrbutton"; > interrupts = <8>; > }; > }; > > See also: > * Documentation/devicetree/bindings/mfd/twl-familly.txt > * Documentation/devicetree/bindings/watchdog/twl4030-wdt.txt > * Documentation/devicetree/bindings/sound/omap-twl4030.txt > * Documentation/devicetree/bindings/mfd/twl4030-power.txt > * Documentation/devicetree/bindings/mfd/twl4030-audio.txt > * Documentation/devicetree/bindings/gpio/gpio-twl4030.txt Wow, that's crazy! It is all one device so put all the bindings into a single file. g, -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html