On Wed, Oct 23, 2013 at 6:41 AM, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote: > On 22 October 2013 22:44, Matt Sealey <neko@xxxxxxxxxxxxx> wrote: >> Any driver that fails probing for an optional property is >> broken and needs fixing. > > I agree, but I note that by this rule all the primecell peripheral > drivers are broken, because the binding docs say that the > "clocks" and "clock-names" properties are optional but if you > omit them from the dt node then the kernel refuses to even > call the driver's probe code. (This is specifically irritating for > QEMU because it means we have to create a dummy clock > node in our device tree just to placate the kernel sufficiently > that we can get it to talk to a PL011 UART model.) I agree this is broken. The amba bus code should allow for non-existent clocks. I thought it did, but maybe this changed or my memory is just broken as well. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
