On Wed, Oct 16, 2013 at 3:38 PM, Leela Krishna Amudala
<l.krishna@xxxxxxxxxxx> wrote:
> Hi Tomasz,
>
> On Wed, Oct 16, 2013 at 12:21 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
>> Hi Leela,
>>
>> On Tuesday 15 of October 2013 16:50:54 Leela Krishna Amudala wrote:
>>> Adds G-Scaler devices to the DT device list
>>>
>>> Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx>
>>> ---
>>> arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++
>>> 1 file changed, 20 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>>> b/arch/arm/boot/dts/exynos5420.dtsi index 7f0296c..f86aeea 100644
>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>> @@ -31,6 +31,8 @@
>>> i2c1 = &i2c_1;
>>> i2c2 = &i2c_2;
>>> i2c3 = &i2c_3;
>>> + gsc0 = &gsc_0;
>>> + gsc1 = &gsc_1;
>>
>> Do you really need these aliases?
>>
>
> Yes, without these aliases probe function fails saying
> [ 1.040000] exynos-gsc 13e00000.gsc: Invalid platform device id: 65517
> [ 1.045000] exynos-gsc: probe of 13e00000.gsc failed with error -22
>
In gsc_probe() function, of_alias_get_id(pdev->dev.of_node, "gsc") is
returning error value,
Hence probe failing.
>>> };
>>>
>>> cpus {
>>> @@ -313,4 +315,22 @@
>>> clocks = <&clock 431>, <&clock 143>;
>>> clock-names = "mixer", "sclk_hdmi";
>>> };
>>> +
>>> + gsc_0: gsc@0x13e00000 {
>>
>> coding style: There should be no 0x in node name and the name should
>> be more meaningful, e.g. video-scaler.
>>
>
> Okay, will change it and post next version of this patch.
>
> Best Wishes,
> Leela Krishna.
>
>> Best regards,
>> Tomasz
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
