Hi Leela, On Tuesday 15 of October 2013 16:50:54 Leela Krishna Amudala wrote: > Adds G-Scaler devices to the DT device list > > Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5420.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > b/arch/arm/boot/dts/exynos5420.dtsi index 7f0296c..f86aeea 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -31,6 +31,8 @@ > i2c1 = &i2c_1; > i2c2 = &i2c_2; > i2c3 = &i2c_3; > + gsc0 = &gsc_0; > + gsc1 = &gsc_1; Do you really need these aliases? > }; > > cpus { > @@ -313,4 +315,22 @@ > clocks = <&clock 431>, <&clock 143>; > clock-names = "mixer", "sclk_hdmi"; > }; > + > + gsc_0: gsc@0x13e00000 { coding style: There should be no 0x in node name and the name should be more meaningful, e.g. video-scaler. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html