Thanks for your review. > -----Original Message----- > From: Wood Scott-B07421 > Sent: 2013年10月12日 星期六 3:08 > To: Tang Yuantian-B29983 > Cc: galak@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linuxppc- > dev@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device > tree > > On Wed, 2013-10-09 at 14:38 +0800, Yuantian.Tang@xxxxxxxxxxxxx wrote: > > From: Tang Yuantian <yuantian.tang@frovider: > > +/ { > > + clockgen: global-utilities@e1000 { > > + compatible = "fsl,p5020-clockgen", "fsl,qoriq-clockgen-1.0"; > > + reg = <0xe1000 0x1000>; > > + clock-frequency = <0>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + sysclk: sysclk { > > + #clock-cells = <0>; > > + compatible = "fsl,qoriq-sysclk-1.0", "fixed-clock"; > > + clock-output-names = "sysclk"; > > + } > > + > > + pll0: pll0@800 { > > + #clock-cells = <1>; > > + reg = <0x800 0x4>; > > + compatible = "fsl,qoriq-core-pll-1.0"; > > + clocks = <&sysclk>; > > + clock-output-names = "pll0", "pll0-div2"; > > + }; > > Where is "ranges" in the global-utilities node? > Will add it thanks. Regards, Yuantian > -Scott > ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f