Hi Linus, On 10/11/13, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad > <prabhakar.csengg@xxxxxxxxx> wrote: >> On 10/11/13, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: >>> On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad >>> <prabhakar.csengg@xxxxxxxxx> wrote: > >>>> +- ti,davinci-gpio-irq-base: Base from where GPIO interrupt numbering >>>> starts. >>> >>> What is this? >>> >>> If I have ever ACKed this I have been drunk. I take it back. >>> >> here is the ACK https://patchwork.kernel.org/patch/2721181/ > > And as suspected that version of the patch did not contain > this strange node property. > The property did exist in the patch 'intc_irq_num', I just renamed it and gave a proper description to it. > Don't keep my ACK on patches if you change basic stuff like > that, they need to be re-acked, this runs the risk of abusing > my trust amongst other subsystem maintainers who might > go and merge this because "aha the GPIO maintainer > thinks that this is OK". > Agreed, I carry forwarded the ACK since it had minor changes. >>> This "base" is a Linux-specific thing and has no place in the >>> device tree, and shall not be there. You have to find some way to >>> avoid this, what do you think some other OS should do with >>> this value... >>> >>> All IRQs in Linux are assumed to be dynamically assigned numbers >>> nowadays, with a property like this you can never switch on >>> SPARSE_IRQ for the DaVinci. >>> >> Can you point to any alternative solution if you have any ? > > First convert this GPIO driver to use an irqdomain to map > HW IRQs to Linux IRQs, and grab a few IRQ descriptors > dynamically off the irq descriptor heap. > Example: commit > a6c45b99a658521291cfb66ecf035cc58b38f206 > "pinctrl/coh901: use irqdomain, allocate irqdescs" > > Then on a longer term convert DaVinci to use dynamically > allocated IRQs for all interrupt controllers, and move it over > to SPARSE_IRQ so you know this works. > Thanks for the pointers. -- Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
