Hi Linus , On 10/11/13, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > On Fri, Oct 4, 2013 at 6:03 PM, Prabhakar Lad > <prabhakar.csengg@xxxxxxxxx> wrote: > >> This patch adds OF parser support for davinci gpio >> driver and also appropriate documentation in gpio-davinci.txt >> located at Documentation/devicetree/bindings/gpio/. >> >> Signed-off-by: KV Sujith <sujithkv@xxxxxx> >> Signed-off-by: Philip Avinash <avinashphilip@xxxxxx> >> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > ^Don't trust this guy. > >> [prabhakar.csengg@xxxxxxxxx: simplified the OF code and also >> the commit message] >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> >> --- >> .../devicetree/bindings/gpio/gpio-davinci.txt | 34 +++++++++++ >> drivers/gpio/gpio-davinci.c | 60 >> +++++++++++++++++++- >> 2 files changed, 91 insertions(+), 3 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> new file mode 100644 >> index 0000000..87abd3b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> @@ -0,0 +1,34 @@ >> +Davinci GPIO controller bindings >> + >> +Required Properties: >> +- compatible: should be "ti,dm6441-gpio" >> + >> +- reg: Physical base address of the controller and the size of memory >> mapped >> + registers. >> + >> +- gpio-controller : Marks the device node as a gpio controller. >> + >> +- interrupts: Array of GPIO interrupt number. >> + >> +- ngpio: The number of GPIO pins supported. >> + >> +- ti,davinci-gpio-irq-base: Base from where GPIO interrupt numbering >> starts. > > What is this? > > If I have ever ACKed this I have been drunk. I take it back. > here is the ACK https://patchwork.kernel.org/patch/2721181/ > This "base" is a Linux-specific thing and has no place in the > device tree, and shall not be there. You have to find some way to > avoid this, what do you think some other OS should do with > this value... > > All IRQs in Linux are assumed to be dynamically assigned numbers > nowadays, with a property like this you can never switch on > SPARSE_IRQ for the DaVinci. > Can you point to any alternative solution if you have any ? -- Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
