Hi, On 10/08/2013 02:44 PM, Yuvaraj Kumar wrote: > On Fri, Oct 4, 2013 at 6:03 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote: >> On Thursday, October 03, 2013 8:32 PM, Bartlomiej Zolnierkiewicz wrote: >>> On Tuesday, October 01, 2013 12:03:01 PM Yuvaraj Kumar C D wrote: >>>> Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible >>>> ahci_platform driver is not sufficient to handle the AHCI PHY and PHY >>>> clock related initialization. >>>> >>>> This patch adds exynos specific ahci sata driver,contained the exynos >>>> specific initialized codes, re-use the generic ahci_platform driver, and >>>> keep the generic ahci_platform driver clean as much as possible. >>>> >>>> This patch depends on the below patch >>>> [1].drivers: phy: add generic PHY framework >>>> by Kishon Vijay Abraham I<kishon@xxxxxx> >>>> >>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxxxx> >>>> --- >>>> drivers/ata/Kconfig | 9 ++ >>>> drivers/ata/Makefile | 1 + >>>> drivers/ata/ahci_exynos.c | 226 +++++++++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 236 insertions(+) >>>> create mode 100644 drivers/ata/ahci_exynos.c >>>> >> >> >> [.....] >> >>>> + priv->phy = devm_phy_get(dev , "sata-phy"); >>>> + if (IS_ERR(priv->phy)) >>>> + return PTR_ERR(priv->phy); >> >> [.....] >> >>> Also please take a look at the following patch: >>> >>> https://lkml.org/lkml/2013/9/19/173 >>> >>> it adds PHY support to ahci_platform driver, maybe it can be used >>> for your needs as well. >> >> I also agree with Bartlomiej Zolnierkiewicz's opinion. >> 'ahci_exynos.c' just calls PHY API, without any additional control >> for Exynos AHCI IP. > In addition to PHY handling,it also deals with the special clock > sclk_sata which is not dealt in ahci_platform.c(certainly exynos > specific). > > Morever there is a wrapper driver to handle the platform specific > things for the sata.Please refer the patch[1] > [1]ata: ti_sata: Add Texas Instruments SATA Wrapper driver > https://lkml.org/lkml/2013/9/19/166 This driver doesn't do anything at the moment since the OMAP hwmod layer takes care of enabling the relevant clocks. So I was planning to drop it for now. > > [2]ahci_imx: add ahci sata support on imx platforms > > I think, if we have platform specific driver like ahci_xxx.c , it > would be better to handle the sata PHY in ahci_xxx.c so that we can > retain and re-use the ahci_platform.c as it is. > The Generic PHY framework [3] has been merged into Greg's usb-next branch. The operations there are pretty generic and IMO the PHY can be handled in the ahci_platform driver. [3] Generic PHY framework https://lkml.org/lkml/2013/9/27/581 cheers, -roger > Further comments will be much appreciated. > >> >> Best regards, >> Jingoo Han >> >>> >>>> + ret = phy_init(priv->phy); >>>> + if (ret < 0) { >>>> + dev_err(dev, "failed to init SATA PHY\n"); >>>> + return ret; >>>> + } >>>> + >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
