On Tue, Oct 01, 2013 at 01:36:33PM +0200, Laurent Pinchart wrote: > Hi Yoshii-san and Simon, > > On Tuesday 24 September 2013 13:52:15 Simon Horman wrote: > > [ Cc Laurent ] > > > > On Tue, Sep 24, 2013 at 01:13:31PM +0900, takasi-y@xxxxxxxxxxxxx wrote: > > > Device tree clock binding document for EMMA Mobile EV2 SMU. > > > Following nodes are defined to describe clock tree. > > > - renesas,emev2-smu > > > - renesas,emev2-smu-clkdiv > > > - renesas,emev2-smu-gclk > > > > I realise this has been entirely consistent in the past and > > even as recently as Linus' pre v3.12-rc2 master branch. > > However, after some recent discussion we are now trying to make our > > compatibility strings consistently of the form renesas,<unit>-<soc>. > > > > With this in mind I believe the strings should be: > > > > - renesas,smu-emev2 > > - renesas,smu-clkdiv-emev2 > > - renesas,smu-gclk-emev2 > > > > To be honest I am not quite sure about the "-clkdiv" and "-gclk" > > bits and I would appreciate some review from others. > > I don't have access to the EMEV2 datasheet so my ability to comment on this is > somehow limited. However, given that the clock hardware is very SoC-specific, > it might make sense to keep the names proposed by Yoshii-san. This would be > consistent with the other clock bindings. Thanks Laurent. If that seems fine by you then it is fine by me. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html