On 01-10-2013 18:33, Nishanth Menon wrote: > On 14:32-20131001, Eduardo Valentin wrote: > minor comments follow >> This patch changes a dtsi file to contain the thermal data > s/changes/introduces? >> for IVA domain on DRA7 and later SoCs. This data will >> enable a thermal shutdown at 125C. >> >> This thermal data can be reused across TI SoC devices. > is'nt it just DRA7 that reuses this - based on dtsi name? For now, yes, but the file is intended to be reusable. just like the file with cpu thermal zone is reusable on omap4/5/dra devices. >> >> Signed-off-by: Eduardo Valentin <eduardo.valentin@xxxxxx> >> --- >> arch/arm/boot/dts/dra7-iva-thermal.dtsi | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 arch/arm/boot/dts/dra7-iva-thermal.dtsi >> >> diff --git a/arch/arm/boot/dts/dra7-iva-thermal.dtsi b/arch/arm/boot/dts/dra7-iva-thermal.dtsi >> new file mode 100644 >> index 0000000..fea0cea >> --- /dev/null >> +++ b/arch/arm/boot/dts/dra7-iva-thermal.dtsi >> @@ -0,0 +1,28 @@ >> +/* >> + * Device Tree Source for DRA7 SoC IVA thermal >> + * >> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/ >> + * Contact: Eduardo Valentin <eduardo.valentin@xxxxxx> >> + * >> + * This file is licensed under the terms of the GNU General Public License >> + * version 2. This program is licensed "as is" without any warranty of any >> + * kind, whether express or implied. >> + */ >> + >> +#include <dt-bindings/thermal/thermal.h> >> + >> +iva_thermal: iva_thermal { >> + polling-delay-passive = <250>; /* milliseconds */ >> + polling-delay = <1000>; /* milliseconds */ >> + >> + /* sensor ID */ > ^^ double tab here? >> + thermal-sensors = <&bandgap 4>; > space after bandgap is good enough? Those tabulation were intentional, to hint that 4 means sensor id. >> + >> + trips { >> + iva_crit: iva_crit { >> + temperature = <125000>; /* milliCelsius */ >> + hysteresis = <2000>; /* milliCelsius */ >> + type = THERMAL_TRIP_CRITICAL; >> + }; >> + }; >> +}; > -- You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin
Attachment:
signature.asc
Description: OpenPGP digital signature
