On Thu, Sep 26, 2013 at 10:36:55AM +0200, Andrew Lunn wrote: > Hi Ezequiel > > +#define CORE_CLOCK_DIVIDER_RATIO_OFFSET 0x8 > ... > > reg = readl(corediv->reg + CORE_CLOCK_DIVIDER_RATIO_OFFSET); > > ... > > +Example: > + > +corediv_clk: corediv-clocks@18740 { > + compatible = "marvell,armada-370-corediv-clock"; > + reg = <0x18740 0x8>; > + #clock-cells = <1>; > + clocks = <&pll>; > +}; > > The reg property seems to be wrong. > Mm.. good catch! Thanks for the review, -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html