Re: [PATCH] ASoC: kirkwood: fix loss of external clock at probe time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Sep 19, 2013 at 11:49:57AM +0200, Jean-Francois Moine wrote:

>  	priv->extclk = devm_clk_get(&pdev->dev, "extclk");
> -	if (!IS_ERR(priv->extclk)) {
> +	if (IS_ERR(priv->extclk)) {
> +		if (np && of_property_match_string(np, "clock-names", "extclk") >= 0)
> +			return -EPROBE_DEFER;
> +	} else {

This one really does seem like something the clock API ought to be
doing, either as standard or with a separate helper - essentially every
driver ought to be doing this for robustness.  Doing it on general
failures is more tricky but in the specific case where we know the clock
should be present but we don't have the driver loaded yet.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux