On 09/16/2013 05:01 PM, Marek Vasut wrote:
> Dear Stephen Warren,
>
>> On 09/13/2013 10:54 AM, Mike Dunn wrote:
>>> This patch adds device tree support to the PXA's PWM driver. Only an OF
>>> match table is added; nothing needs to be extracted from the device tree
>>> node. The existing ID table is reused for the match table data.
>>>
>>> Tested on a Palm Treo 680 (both platform data and DT cases).
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pxa-pwm.txt
>>> b/Documentation/devicetree/bindings/pwm/pxa-pwm.txt
>>>
>>> +- compatible: should be one of:
>>> + - "marvell,pxa250-pwm"
>>> + - "marvell,pxa270-pwm"
>>> + - "marvell,pxa168-pwm"
>>> + - "marvell,pxa910-pwm"
>>
>> Not just one of, but possible more than one...
>>
>>> diff --git a/arch/arm/boot/dts/pxa27x.dtsi
>>> b/arch/arm/boot/dts/pxa27x.dtsi
>>>
>>> + pwm0: pwm@40b00000 {
>>> + compatible = "marvell,pxa270-pwm";
>>
>> I thought the assertion was that pax270 and pxa250 were both compatible?
>> If so, that should be:
>>
>> compatible = "marvell,pxa270-pwm", "marvell,pxa250-pwm";
>
> I see what you mean with the compatible strings ... but if we have this
> "fallback" compatiblity string, do we also need the table of all chips sporting
> the IP block in the driver itself?
I would assume the driver can just support "marvell,pxa250-pwm" for now.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
