Op 11 sep. 2013, om 08:00 heeft Joel Fernandes <joelf@xxxxxx> het volgende geschreven: > On 09/11/2013 12:18 AM, Koen Kooi wrote: >> >> Op 10 sep. 2013, om 22:14 heeft Joel Fernandes <joelf@xxxxxx> het volgende geschreven: >> >>> On 09/10/2013 02:39 PM, Koen Kooi wrote: >>>> >>>> Op 10 sep. 2013, om 21:24 heeft Joel Fernandes <joelf@xxxxxx> het volgende geschreven: >>>> >>>>> Here are last few patches required to add EDMA and MMC/SPI support for AM33xx. >>>>> >>>>> Now that all dependent DMA patches and fixes are in linux next or mainline, except >>>>> for [1] which should go in for 3.12 -rc cycle, it is safe to enable MMC and SPI support >>>>> and this patch series enables it. These are originally Matt Porter's patches with >>>>> changes to make it work with recent kernels, addition of irq, memory resources and >>>>> enable other extra properties. >>>>> >>>>> These patches should cleanly apply on master branch after Koen's patch [2] for basic >>>>> BBB DT support is applied. >>>>> >>>>> MMC support is enabled for: Beaglebone, AM335x EVM and EVM-SK boards. MMC support >>>>> for BBB is intentionally not added due to custom fixes and other patches that are >>>>> in Koen's tree and which will be separately submitted by him. >>>> >>>> Correct, but your patches for MMC support on BBW are missing the card detect entries to make it hotplug work. >>> >>> I thought it was determined that this would be submitted by you separately after >>> rebasing as we discussed [1] and [2]. >> >> I have no problem submitting that, I just think it's weird that the patch you submitted contains a known broken version for BBW. > > There's nothing "broken" about $subject series. Please don't confuse maintainers > by using wrong words like that. This series is perfectly OK as such to be merged. But plugging in an SD card doesn't work in this series, I'd call that broken. > Further, I am puzzled by all this noise because card-detect additions were > initially agreed to be posted separately by you along with other custom DTS for > BBW MMC. I agreed to post the mmc fixes needed for BBW and BBB, so I assumed you'd drop all beaglebone entries from your series. > Its obvious I wouldn't squash patches that we _agreed_ you would send > out- and that are especially additions than any real fixes. Hopefully this makes > it clear, if you need any help please let me know. Right, so now your patch series will add a half-assed DT entry which only works if the uSD card is present at boot. Anyway, fixup series underway already > > Thanks! > > -Joel > > >>> >>> [1] https://lkml.org/lkml/2013/9/6/183 >>> [2] http://marc.info/?l=linux-omap&m=137879246709612&w=2 >>> >>> >>> Regards, >>> >>> -Joel >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
