> Subject: Re: [PATCHv3 1/4] pwm: Add Freescale FTM PWM driver support > > On Fri, Sep 06, 2013 at 04:08:24PM +0800, Xiubo Li wrote: > > The FTM PWM device can be found on Vybrid VF610 Tower and Layerscape > LS-1 SoCs. > > > > + > > +static int fsl_pwm_probe(struct platform_device *pdev) { > > + int ret = 0; > > + struct fsl_pwm_chip *fpc; > > + struct resource *res; > > + > > + fpc = devm_kzalloc(&pdev->dev, sizeof(*fpc), GFP_KERNEL); > > You don't have to output a message when kzalloc fails, but still you > should check for the result and return an error if necessary. > Okey, I will. -- Xiubo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html