On Tue, Sep 03, 2013 at 12:26:23PM +0800, Fugang Duan wrote: > Add fec phy gpio reset for imx6sl evk board. imx6sl evk board > use GPIO4_21 to do phy reset, so add phy-reset-gpios and > phy-reset-duration propery initial for fec device node. > > Signed-off-by: Fugang Duan <B38611@xxxxxxxxxxxxx> I have to drop this patch for now, because it causes a regression for me. Before this patch, we can at least get a working fec driver in kernel if U-Boot sets it up properly, e.g. we download kernel from network. But with the patch, the fec driver stops working on linux-next in the same use case. Shawn > --- > arch/arm/boot/dts/imx6sl-evk.dts | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts > index 2886a59..c4d32a5 100644 > --- a/arch/arm/boot/dts/imx6sl-evk.dts > +++ b/arch/arm/boot/dts/imx6sl-evk.dts > @@ -23,6 +23,8 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_fec_1>; > phy-mode = "rmii"; > + phy-reset-gpios = <&gpio4 21 0>; /* GPIO4_21 */ > + phy-reset-duration = <1>; > status = "okay"; > }; > > @@ -38,6 +40,7 @@ > MX6SL_PAD_SD2_DAT7__GPIO5_IO00 0x17059 > MX6SL_PAD_SD2_DAT6__GPIO4_IO29 0x17059 > MX6SL_PAD_REF_CLK_32K__GPIO3_IO22 0x17059 > + MX6SL_PAD_FEC_TX_CLK__GPIO4_IO21 0x80000000 > >; > }; > }; > -- > 1.7.1 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html