On Thu, Sep 05, 2013 at 02:50:32PM +0100, Mark Brown wrote: > On Thu, Sep 05, 2013 at 05:30:26PM +0800, Huang Shijie wrote: > > 于 2013年09月05日 17:11, Gupta, Pekon 写道: > > > >Anyway, if you really want to continue with this is, then please re-name > > >include/linux/mtd/spi-nor.h to > > >include/linux/mtd/spi-fsl-quadspi.h > > >because something specific for your driver should not conflict with > > >generic spi-nor framework added later. > > > i think there is no specific thing for this driver. The S25FL128S is > > a common flash, > > other person may uses it too. Could you show me what is specific? > > > so, i prefer to spi-nor.h. > > Looking at the current header there just seem to be defines in there, no > abstraction for the chips. Perhaps that is what is missing? we do not need any abstraction for this chip, we only need the SPI NOR commands, such as Quad read / DDR quad read. thanks Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html