On Mon, Sep 02, 2013 at 07:10:53AM +0000, Lu Jingchang-B35083 wrote: > > -----Original Message----- > > From: Vinod Koul [mailto:vinod.koul@xxxxxxxxx] > > Sent: Monday, September 02, 2013 12:51 PM > > To: Lu Jingchang-B35083 > > Cc: shawn.guo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- > > kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH v4 3/3] dma: Add Freescale eDMA engine driver support > > > > On Thu, Aug 29, 2013 at 03:32:04AM +0000, Lu Jingchang-B35083 wrote: > > > > Please use a right MUA and wrap your lines at 80chars... > > > [Lu Jingchang] > > No need to put your name :) > [Lu Jingchang-b35083] > Aha, the Microsoft Outlook adds this automatically with default option. You can change that!! > > > > > Ok, if it is needed, I will add residue calculation in the next version. > > Yes this is needed > > > > > > > +static bool fsl_edma_filter_fn(struct dma_chan *chan, void > > *fn_param) > > > > > +{ > > > > > + struct fsl_edma_filter_param *fparam = fn_param; > > > > > + struct fsl_edma_chan *fsl_chan = to_fsl_edma_chan(chan); > > > > > + > > > > > + if (fsl_chan->edmamux->mux_id != fparam->mux_id) > > > > > + return false; > > > > > + > > > > > + fsl_chan->slot_id = fparam->slot_id; > > > > > + chan->private = fn_param; > > > > why do you need to use chan->private? > > > [Lu Jingchang] > > > The private used here is to store the slot_id information, which must > > be used > > > by the DMAMUX in alloc_chan_resources function. Thanks. > > Why dont you pass this in struct dma_slave_config memeber slave_id for > > this. > [Lu Jingchang-b35083] > I will drop this private and setup the slave_id directly in the filter function. why in filter? before calling prepare function you can set the slave config ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
