From: Ben Hutchings [mailto:bhutchings@xxxxxxxxxxxxxx] Data: Friday, August 30, 2013 2:49 AM > To: Dan Carpenter > Cc: Grant Likely; Rob Herring; David S. Miller; Estevam Fabio-R49496; Li > Frank-B20596; Jim Baxter; Duan Fugang-B38611; netdev@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; kernel-janitors@xxxxxxxxxxxxxxx > Subject: Re: [patch v2] net/fec: cleanup types in fec_get_mac() > > On Thu, 2013-08-29 at 11:25 +0300, Dan Carpenter wrote: > > My static checker complains that on some arches unsigned longs can be > > 8 characters which is larger than the buffer is only 6 chars. > > Additionally, Ben Hutchings points out that the buffer actually holds > > big endian data and the buffer we are reading from is CPU endian. > > It's not really as clear-cut as that. :-) But I think it's slightly more > logical this way. > Yes, it is not clear, pls remove somebody's name from the commit log. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Reviewed-by: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> > > > --- > > v2: fix endian annotations and reverse the beXX_to_cpu() calls so that > > they say cpu_to_beXX(). > > > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > > b/drivers/net/ethernet/freescale/fec_main.c > > index fdf9307..0b12866 100644 > > --- a/drivers/net/ethernet/freescale/fec_main.c > > +++ b/drivers/net/ethernet/freescale/fec_main.c > > @@ -1100,10 +1100,10 @@ static void fec_get_mac(struct net_device *ndev) > > * 4) FEC mac registers set by bootloader > > */ > > if (!is_valid_ether_addr(iap)) { > > - *((unsigned long *) &tmpaddr[0]) = > > - be32_to_cpu(readl(fep->hwp + FEC_ADDR_LOW)); > > - *((unsigned short *) &tmpaddr[4]) = > > - be16_to_cpu(readl(fep->hwp + FEC_ADDR_HIGH) >> 16); > > + *((__be32 *) &tmpaddr[0]) = > > + cpu_to_be32(readl(fep->hwp + FEC_ADDR_LOW)); > > + *((__be16 *) &tmpaddr[4]) = > > + cpu_to_be16(readl(fep->hwp + FEC_ADDR_HIGH) >> 16); > > iap = &tmpaddr[0]; > > } > > > > -- > Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; > that's the marketing department's job. > They asked us to note that Solarflare product names are trademarked. > ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
