On Friday 23 August 2013 01:24 PM, Daniel Mack wrote: > On 23.08.2013 19:19, Santosh Shilimkar wrote: >> On Friday 23 August 2013 01:09 PM, Sekhar Nori wrote: >>> On 8/23/2013 10:26 PM, Santosh Shilimkar wrote: > >>>> So just stick the IP version or call it cpsw-v1... cpsw-v2 etc. >>> >>> If this could be handled using IP version then the right way would be to >>> just read the IP version from hardware and use it. No need of DT property. >>> >> Thats fine as well but I thought the patch needed additional properties like >> CM reg-address come from DT and hence the separate compatible. If you can >> manage without that, thats even better. > > We can't, that's the whole point :) > I saw that from the patch :) > Well, theoretically, we could for now, but that's not a clean solution. > Again: the problem here is that the control port is separated from the > cpsw core, and so we have to implement something specific for the AM3352 > SoC. I know that's a violation of clean and generic driver ideas, but > there's no way we can assume that every cpsw v2 ip block has a control > port that is compatible to the one found on am335x chips. > But there is a possibility that other SOC will just use the same control module approach. So using a revision IP is just fine. BTW, CPSW is not the only driver where control module is used. There are many examples like USB, MMC etc There is nothing wrong in using the version info and associating the additional functionality with it. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
