On Tue, Aug 20, 2013 at 10:30:34AM +0100, Sascha Hauer wrote: > On Tue, Aug 20, 2013 at 11:11:19AM +0200, Linus Walleij wrote: > > On Thu, Jun 6, 2013 at 2:16 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > > > > +++ b/arch/arm/boot/dts/dbx5x0.dtsi > > > @@ -572,6 +572,8 @@ > > > v-i2c-supply = <&db8500_vape_reg>; > > > > > > clock-frequency = <400000>; > > > + clocks = <&prcc_kclk 3 3>, <&prcc_pclk 3 3>; > > > + clock-names = "nmk-i2c.0", "apb_pclk"; > > Why do most clocks in this series have the instance number in the clock > names? This looks very wrong to me. +1. The clock names should be the input names to the unit, they shouldn't vary per instance. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
