Hi Markus, The patch looks good overall, just a little nitpick about the commit message. On Monday 19 of August 2013 11:59:21 Markus Mayer wrote: > GPIO device tree bindings for the Broadcom bcm281xx family of chips Device tree bindings are sets of properties and subnodes defined for device nodes used to describe those devices. In other words, bindings are what you have described in numerous files Documentation/devicetree/bindings. What this patch is adding is a device node for the GPIO controller of bcm11351. Other than that: Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html