On 08/14/2013 05:22 AM, Sachin Kamat wrote: > Updated the documentation as per the latest driver implementation. > While at it also fixed some trivial typos. > diff --git a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt > +- clocks : Clock IDs array as required by the controller. > +- clock-names : names of clocks listed in clocks property in the same order > + as requested by the controller driver. This is wrong. The DT binding must specify the set of required clock-names, not the driver; bindings must be self-contained. Also, the order shouldn't matter, since everything should be looked up by name; all that matters is the entries in clocks/clock-names match. > Optional properties: > -- #address-cells: should be '1' when usbphy node has a child node with 'reg' > +- #address-cellsi : should be '1' when usbphy node has a child node with 'reg' > property. Type "cellsi". What should the value be if there is no child node? In other words, I think just delete the text "when usbphy node has a child node with 'reg' property.". Same for size-cells. > -- #size-cells: should be '1' when usbphy node has a child node with 'reg' > +- #size-cells : should be '1' when usbphy node has a child node with 'reg' > property. I don't think it's worth changing the binding doc just to add a space before the colon... It looks better the first way, although unfortunately many DT binding docs have the extra space. > +- clocks : Clock IDs array as required by the controller. > +- clock-names : names of clocks correseponding to IDs in the clock property > as requested by the controller driver. May as well s/correseponding/corresponding/. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
