Seungwon and Derek, On Mon, Aug 12, 2013 at 3:33 AM, Seungwon Jeon <tgih.jun@xxxxxxxxxxx> wrote: > On Wed, August 07, 2013, Derek Basehore >> If we keep power for suspend on a host for dw_mmc, don't disable vmmc-supply >> regulator when suspending the host. > > I have a trivial comment. > It would be better to add some macro for checking MMC_PM_KEEP_POWER. > And I just wonder how the problem is silent. Origin code has stood up somewhat long. > Did you see? > > Acked-by: Seungwon Jeon <tgih.jun@xxxxxxxxxxx> > > Thanks, > Seungwon Jeon > >> >> Signed-off-by: Derek Basehore <dbasehore@xxxxxxxxxxxx> >> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx> >> --- >> drivers/mmc/host/dw_mmc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) Though I reviewed this originally, I'd actually propose not landing it. I've spent more time with the regulator code in dw_mmc and currently believe that the regulators should be enabled / disabled in MMC_POWER_UP / MMC_POWER_OFF. When we do that then the mmc core will handle MMC_PM_KEEP_POWER. You can see my current thoughts on this in <https://gerrit.chromium.org/gerrit/#/c/65263/>. I will try to post that upstream before too long, but feel free to let me know any comments. -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
