On 08/09/2013 07:15 AM, Tomasz Figa wrote: > Hi Chanho, > > On Friday 09 of August 2013 16:40:53 Chanho Park wrote: >> This patch describes each nodes of rotator and specifies a example how to >> bind it. >> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt >> +* Samsung Image Rotator >> + >> +Required properties: >> + - compatible : value should be following: >> + (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210 >> + (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412 >> + (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250 Is "rotator" the name that the HW documentation uses to refer to this block? If so, those compatible values seem fine. If not, they seem slightly too generic for me; perhaps better to use the raw HW block name? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
