Hi Chanho,
On Friday 09 of August 2013 16:40:53 Chanho Park wrote:
> This patch describes each nodes of rotator and specifies a example how to
> bind it.
>
> Signed-off-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> Cc: Thomas Abraham <thomas.abraham@xxxxxxxxxx>
> Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx>
> Cc: Inki Dae <inki.dae@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/gpu/samsung-rotator.txt | 26
> ++++++++++++++++++++ 1 file changed, 26 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/gpu/samsung-rotator.txt
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt new file
> mode 100644
> index 0000000..31ee7b5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> @@ -0,0 +1,26 @@
> +* Samsung Image Rotator
> +
> +Required properties:
> + - compatible : value should be following:
> + (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
> + (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
> + (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
> +
> + - reg : Physical base address of the IP registers and length of memory
> + mapped region.
> +
> + - interrupts : Interrupt number of Rotator
What about: interrupt specifier for rotator interrupt, according to format
specific to interrupt parent.
> +
> + - clocks : Clock number described in
> Documentations/devicetree/binding/clock. +
Perhaps: clock specifier for rotator clock, according to generic clock
bindings.
> + - clock-names : Clock name.
Names of clocks specified in "clocks" property. For exynos rotator this
property should contain only one name: "rotator".
> +Example:
> + rotator: rotator@12800000 {
I wonder if we shouldn't use a more generic name here, according to ePAPR
node naming recommendation.
> + compatible = "samsung,exynos4210-rotator";
> + reg = <0x12810000 0x1000>;
Typo. Node has 12800000 in unit-address suffix, but this property has
12810000 instead.
> + interrupts = <0 83 0>;
> + clocks = <&clock 278>;
> + clock-names = "rotator";
> + status = "disabled";
Status property should be omitted from this example, as it's not a part of
this binding.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
