On Tue, Dec 03, 2024 at 02:14:46PM +0530, Ayush Singh wrote:
> On 03/12/24 13:44, Geert Uytterhoeven wrote:
> > Hi Ayush,
> >
> > On Tue, Dec 3, 2024 at 8:29 AM Ayush Singh <ayush@xxxxxxxxxxxxxxx> wrote:
> > > On 03/12/24 09:47, David Gibson wrote:
> > > > On Sat, Nov 16, 2024 at 08:30:19PM +0530, Ayush Singh wrote:
> > > > > --- a/livetree.c
> > > > > +++ b/livetree.c
> > > > > @@ -908,6 +908,13 @@ static bool any_fixup_tree(struct dt_info *dti, struct node *node)
> > > > > if (!get_node_by_ref(dti->dt, m->ref))
> > > > > return true;
> > > > > }
> > > > > + m = prop->val.markers;
> > > > > + for_each_marker_of_type(m, REF_PATH)
> > > > > + {
> > > >
> > > > Opening brace goes on the same line as the for_each()
> > > >
> > > > > + if (m->ref) {
> > > >
> > > >
> > > > As for phandle references, you don't need to emit a fixup if the
> > > > reference can be resolved within the current tree, so you want a
> > > > get_node_by_ref() before returning true.
> > > >
> > > > > + return true;
> > > > > + }
> > > >
> > > > No braces around single statements in dtc style.
> > >
> > > Is there any clang-format config or something for dtc? I am currently
> > > using the format config from Linux kernel.
> >
> > The above are the same rules as the Linux kernel style rules?
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
>
> My bad, I should have put the response on some other line. I was just asking
> if it would be fine to use configs from linux kernel from my next patch
> series since dtc does not seem to have one in it's tree.
>
> I was not using any format and checkpatch config right now.
I'd be happy to look at a patch adding clang format config to the dtc
tree (you can use the kernel one as a starting point).
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
