Re: [PATCH 1/5] dtc: Allow path fixups in overlays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi Ayush,

On Tue, Dec 3, 2024 at 8:29 AM Ayush Singh <ayush@xxxxxxxxxxxxxxx> wrote:
> On 03/12/24 09:47, David Gibson wrote:
> > On Sat, Nov 16, 2024 at 08:30:19PM +0530, Ayush Singh wrote:
> >> --- a/livetree.c
> >> +++ b/livetree.c
> >> @@ -908,6 +908,13 @@ static bool any_fixup_tree(struct dt_info *dti, struct node *node)
> >>                      if (!get_node_by_ref(dti->dt, m->ref))
> >>                              return true;
> >>              }
> >> +            m = prop->val.markers;
> >> +            for_each_marker_of_type(m, REF_PATH)
> >> +            {
> >
> > Opening brace goes on the same line as the for_each()
> >
> >> +                    if (m->ref) {
> >
> >
> > As for phandle references, you don't need to emit a fixup if the
> > reference can be resolved within the current tree, so you want a
> > get_node_by_ref() before returning true.
> >
> >> +                            return true;
> >> +                    }
> >
> > No braces around single statements in dtc style.
>
> Is there any clang-format config or something for dtc? I am currently
> using the format config from Linux kernel.

The above are the same rules as the Linux kernel style rules?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux