Hi Ayush,
On Thu, 29 Aug 2024 at 08:17, Ayush Singh <ayush@xxxxxxxxxxxxxxx> wrote:
>
> On 8/29/24 19:34, Simon Glass wrote:
>
> > Hi Ayush,
> >
> > On Tue, 27 Aug 2024 at 11:55, Ayush Singh <ayush@xxxxxxxxxxxxxxx> wrote:
> >> Simple test to build a device tree with /append-property/.
> >>
> >> Signed-off-by: Ayush Singh <ayush@xxxxxxxxxxxxxxx>
> >> ---
> >> tests/run_tests.sh | 3 +++
> >> tests/test_tree1_append.dts | 21 +++++++++++++++++++++
> >> 2 files changed, 24 insertions(+)
> >>
> >> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> >> index 937b128..ac0dc05 100755
> >> --- a/tests/run_tests.sh
> >> +++ b/tests/run_tests.sh
> >> @@ -708,6 +708,9 @@ dtc_tests () {
> >> run_dtc_test -I dts -O dtb -o dtc_tree1_delete.test.dtb "$SRCDIR/test_tree1_delete.dts"
> >> tree1_tests dtc_tree1_delete.test.dtb
> >>
> >> + # Check prop append functionality
> >> + run_dtc_test -I dts -O dtb -o dtc_tree1_append.test.dtb "$SRCDIR/test_tree1_append.dts"
> >> +
> > How does this check that something actually happened? From your cover
> > letter, it seems that you might send a v2, but I'm just checking?
>
> Yeah, it tries to build it and that's all. I am not sure if
> `run_dtc_test` fails if the command fails.
>
>
> I can see there are helpers like `check_path` but is there any helper to
> check the value of a property? If not, I can try to write one.
The fdtget tests do some of that.
Regards,
Simon
