Hi Ayush,
On Tue, 27 Aug 2024 at 11:55, Ayush Singh <ayush@xxxxxxxxxxxxxxx> wrote:
>
> Simple test to build a device tree with /append-property/.
>
> Signed-off-by: Ayush Singh <ayush@xxxxxxxxxxxxxxx>
> ---
> tests/run_tests.sh | 3 +++
> tests/test_tree1_append.dts | 21 +++++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/tests/run_tests.sh b/tests/run_tests.sh
> index 937b128..ac0dc05 100755
> --- a/tests/run_tests.sh
> +++ b/tests/run_tests.sh
> @@ -708,6 +708,9 @@ dtc_tests () {
> run_dtc_test -I dts -O dtb -o dtc_tree1_delete.test.dtb "$SRCDIR/test_tree1_delete.dts"
> tree1_tests dtc_tree1_delete.test.dtb
>
> + # Check prop append functionality
> + run_dtc_test -I dts -O dtb -o dtc_tree1_append.test.dtb "$SRCDIR/test_tree1_append.dts"
> +
How does this check that something actually happened? From your cover
letter, it seems that you might send a v2, but I'm just checking?
> # Check omit-if-no-ref functionality
> run_dtc_test -I dts -O dtb -o omit-no-ref.test.dtb "$SRCDIR/omit-no-ref.dts"
> run_test check_path omit-no-ref.test.dtb not-exists "/node1"
> diff --git a/tests/test_tree1_append.dts b/tests/test_tree1_append.dts
> new file mode 100644
> index 0000000..953095d
> --- /dev/null
> +++ b/tests/test_tree1_append.dts
> @@ -0,0 +1,21 @@
> +/dts-v1/;
> +
> +/include/ "test_tree1.dts"
> +
> +/ {
> + nonexistant-property = <0x00000000>;
> +
> + subnode@1 {
> + sub-prop = <0>;
> + str-prop = "0";
> + };
> +};
> +
> +/ {
> + /append-property/ nonexistant-property = <0x00000001 0x00000002>;
> +
> + subnode@1 {
> + /append-property/ sub-prop = <1 2>;
> + /append-property/ str-prop = "1", "2";
> + };
> +};
>
> --
> 2.46.0
>
>
Regards,
Simon
