Hi David, On Sun, 11 Aug 2024 at 20:01, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Aug 12, 2024 at 11:51:05AM +1000, David Gibson wrote: > > On Sun, Aug 11, 2024 at 09:02:48AM -0600, Simon Glass wrote: > > > From: Gua Guo <gua.guo@xxxxxxxxx> > > > > > > Windows apparently builds pylibfdt if swig is declared as a dependency > > > in the setup file. Otherwise it must be installed manually and Windows > > > does not sport a package manager, so this is hard for users. > > > > > > This change seems to have no ill effects on Linux, at least. > > > > > > So add a new setup_requires line. > > > > > > Signed-off-by: Gua Guo <gua.guo@xxxxxxxxx> > > > Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> > > > > Applied. > > Oops, spoke too soon. While this works locally for me, it breaks on > the github CI. See: > > https://github.com/dgibson/dtc/actions/runs/10344711112 > > > We do have windows build in our github actions. It would be great if > > a test for building pylibfdt properly there were added. > > This remains true, once the Linux breakage is fixed. Thanks for that. We'll try to figure out that MSYS2 error. Regards, Simon > > -- > David Gibson (he or they) | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you, not the other way > | around. > http://www.ozlabs.org/~dgibson
