On Sun, Aug 11, 2024 at 09:02:48AM -0600, Simon Glass wrote: > From: Gua Guo <gua.guo@xxxxxxxxx> > > Windows apparently builds pylibfdt if swig is declared as a dependency > in the setup file. Otherwise it must be installed manually and Windows > does not sport a package manager, so this is hard for users. > > This change seems to have no ill effects on Linux, at least. > > So add a new setup_requires line. > > Signed-off-by: Gua Guo <gua.guo@xxxxxxxxx> > Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx> Applied. We do have windows build in our github actions. It would be great if a test for building pylibfdt properly there were added. > --- > This was picked up from: > > https://github.com/devicetree-org/pylibfdt/pull/2 > > setup.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/setup.py b/setup.py > index 52844ce..6efdae6 100755 > --- a/setup.py > +++ b/setup.py > @@ -76,6 +76,7 @@ setup( > cmdclass = {'build_py' : BuildPy}, > author='Simon Glass', > author_email='sjg@xxxxxxxxxxxx', > + setup_requires = ['swig'], > description='Python binding for libfdt', > ext_modules=[libfdt_module], > package_dir={'': os.path.join(srcdir, 'pylibfdt')}, -- David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
