On Mon, Jan 03, 2022 at 02:22:32PM +0400, Marc-André Lureau wrote: > Hi Simon > > On Mon, Jan 3, 2022 at 2:18 PM Simon Glass <sjg@xxxxxxxxxxxx> wrote: > > > > Hi Marc-André, > > > > On Mon, 3 Jan 2022 at 03:04, Marc-André Lureau > > <marcandre.lureau@xxxxxxxxxx> wrote: > > > > > > Hi Simon > > > > > > On Mon, Jan 3, 2022 at 1:59 PM Simon Glass <sjg@xxxxxxxxxxxx> wrote: > > > > > > > > Hi Marc-André, > > > > > > > > On Mon, 3 Jan 2022 at 00:39, <marcandre.lureau@xxxxxxxxxx> wrote: > > > > > > > > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > > > > > > > You can build the static library by running meson configure > > > > > -Ddefault_library=both or static. > > > > > > > > > > This reverts commit 5216f3f1bbb70aef463b6cd78dbbb0f4c4c71606. > > > > > > > > What is the reason for the revert? > > > > > > Did you miss the comment above? > > > > I think you alluded to it but it is good to be explicit as to the motivation. > > > > > > > > There is no need to have a static_library() to build a static library. > > > library() handles both kinds, you just have to specify with the > > > -Ddefault_library option what you want. > > > > But don't we want the standard build to produce both static and > > dynamic libraries? > > If we wanted that (this is not the most common option these days), the > recommended way is to set project() default_options. Hmm.. the existing make behaviour is to build both libraries by default, so I'd prefer to keep that with meson unless there's a compelling reason not to. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
