Hi Simon
On Mon, Jan 3, 2022 at 2:18 PM Simon Glass <sjg@xxxxxxxxxxxx> wrote:
>
> Hi Marc-André,
>
> On Mon, 3 Jan 2022 at 03:04, Marc-André Lureau
> <marcandre.lureau@xxxxxxxxxx> wrote:
> >
> > Hi Simon
> >
> > On Mon, Jan 3, 2022 at 1:59 PM Simon Glass <sjg@xxxxxxxxxxxx> wrote:
> > >
> > > Hi Marc-André,
> > >
> > > On Mon, 3 Jan 2022 at 00:39, <marcandre.lureau@xxxxxxxxxx> wrote:
> > > >
> > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > > >
> > > > You can build the static library by running meson configure
> > > > -Ddefault_library=both or static.
> > > >
> > > > This reverts commit 5216f3f1bbb70aef463b6cd78dbbb0f4c4c71606.
> > >
> > > What is the reason for the revert?
> >
> > Did you miss the comment above?
>
> I think you alluded to it but it is good to be explicit as to the motivation.
>
> >
> > There is no need to have a static_library() to build a static library.
> > library() handles both kinds, you just have to specify with the
> > -Ddefault_library option what you want.
>
> But don't we want the standard build to produce both static and
> dynamic libraries?
>
If we wanted that (this is not the most common option these days), the
recommended way is to set project() default_options.
> Regards,
> Simon
>
> > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > > > ---
> > > > libfdt/meson.build | 5 -----
> > > > 1 file changed, 5 deletions(-)
> > > >
> > > > diff --git a/libfdt/meson.build b/libfdt/meson.build
> > > > index 71f29b61e870..0307ffb8d7b9 100644
> > > > --- a/libfdt/meson.build
> > > > +++ b/libfdt/meson.build
> > > > @@ -24,11 +24,6 @@ libfdt = library(
> > > > install: true,
> > > > )
> > > >
> > > > -libfdt_a = static_library(
> > > > - 'fdt', sources,
> > > > - install: true,
> > > > -)
> > > > -
> > > > libfdt_inc = include_directories('.')
> > > >
> > > > libfdt_dep = declare_dependency(
> > > > --
> > > > 2.34.1.8.g35151cf07204
> > > >
> > >
> >
>
