On Tue, Jun 08, 2021 at 01:25:03PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jun 8, 2021 at 7:54 AM David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> > wrote: > > > On Mon, Dec 07, 2020 at 05:00:55PM +0400, marcandre.lureau@xxxxxxxxxx > > wrote: > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > > > This avoids maintaining two build systems, and update the documentation. > > > > > > Makefile now wrap meson, so that make all/check/checkm/clean/install > > > continue working as they used to. > > > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > Sorry I've neglected this so long. I finally got around to lookup up > > a cheatsheet for how to use meson "natively" to understand this > > better. > > > > Couple of issues with this path though: > > > > > --- > > > Makefile | 380 ++----------------------------------- > > > Makefile.convert-dtsv0 | 14 -- > > > Makefile.dtc | 23 --- > > > Makefile.utils | 31 --- > > > README | 24 ++- > > > libfdt/Makefile.libfdt | 18 -- > > > pylibfdt/Makefile.pylibfdt | 30 --- > > > tests/Makefile.tests | 100 ---------- > > > > First, it no longer applies clean due to some added tests. Can you > > rebase please. > > > > Sure, https://github.com/elmarco/dtc/tree/meson-next > > > > > +checkm: > > > + WITH_VALGRIND=1 meson test -C $(BUILD_DIR) -v > > > > Second, the valgrind stuff doesn't seem to work. I tried > > "WITH_VALGRIND=1 meson test" and it completes much to fast to actually > > be using valgrind. Also it doesn't give any error if valgrind isn't > > installed. > > > > Oh? I get this: > /home/elmarco/src/dtc/tests/run_tests.sh: line 75: valgrind: command not > found > > And when valgrind is installed it uses it and takes ages to complete the > tests. Huh. Yet for me it does not yekko:~/src/dtc/tmp (main)$ time meson test ninja: Entering directory `/home/dwg/src/dtc/tmp' [2/2] Generating pylibfdt with a custom command 1/1 run-test OK 2.67s Ok: 1 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 0 Timeout: 0 Full log written to /home/dwg/src/dtc/tmp/meson-logs/testlog.txt real 0m3.015s user 0m1.862s sys 0m1.197s yekko:~/src/dtc/tmp (main)$ time env WITH_VALGRIND=1 meson test ninja: Entering directory `/home/dwg/src/dtc/tmp' [2/2] Generating pylibfdt with a custom command 1/1 run-test OK 2.47s Ok: 1 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 0 Timeout: 0 Full log written to /home/dwg/src/dtc/tmp/meson-logs/testlog.txt real 0m2.836s user 0m1.838s sys 0m1.163s I have no idea how to debug that... > > It's also not ideal that the output from "meson test" is trivial with > > all the content now in the meson log file. Assuming we can sort out > > this first part, would you be willing to help convert the existing > > testsuite / testrunner to be more "meson native" so we can improve > > that? > > > > Certainly, I can eventually take a look when I have time, or help anybody > in this task. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
